quic: cleaning up redundant tests#16660
Conversation
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
danzh2010
left a comment
danzh2010
left a comment
There was a problem hiding this comment.
Thanks for cleaning up!
|
|
||
| auto response = sendRequestAndWaitForResponse(default_request_headers_, 0, response_headers, 0); | ||
| auto response = sendRequestAndWaitForResponse(request_headers, 0, response_headers, 0); | ||
| if (downstreamProtocol() == Http::CodecClient::Type::HTTP3) { |
There was a problem hiding this comment.
no need to check envoy.reloadable_features.header_map_correctly_coalesce_cookies?
There was a problem hiding this comment.
given there was no CI which tested with it flipped I think that's fine
They were added to distinguish downstream and upstream flow control performance problems more easily, i.e. flow control window. They have the same coverage as those in protocol integration tests, made debugging easier. |
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
3 participants
the only ones I was unsure of were UpstreamReadDisabledOnGiantResponseBody vs DownstreamReadDisabledOnGiantPost vs LargeFlowControlOnAndGiantBody
it looks like small request / large response vs large request / small response vs large request / large response.
protocol integration test has large request / large response which I think is sufficient but lmk if I'm missing something.